From e8b8ea560247518ff932a79ba7159da2de9684b2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 15 Apr 2026 03:14:55 +0000 Subject: [PATCH] Address review feedback for Groq provider changes Agent-Logs-Url: https://github.com/AkhilKonduru1/Atoll/sessions/d40c666d-f589-48ca-9539-1fd33c799962 Co-authored-by: AkhilKonduru1 <210101196+AkhilKonduru1@users.noreply.github.com> --- .../components/ScreenAssistant/ModelSelectionPanel.swift | 3 ++- DynamicIsland/managers/ScreenAssistantManager.swift | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/DynamicIsland/components/ScreenAssistant/ModelSelectionPanel.swift b/DynamicIsland/components/ScreenAssistant/ModelSelectionPanel.swift index f369a38..a9f7758 100644 --- a/DynamicIsland/components/ScreenAssistant/ModelSelectionPanel.swift +++ b/DynamicIsland/components/ScreenAssistant/ModelSelectionPanel.swift @@ -117,6 +117,7 @@ class ModelSelectionPanel: NSPanel { // MARK: - Model Selection View struct ModelSelectionView: View { + private let primaryProviders: [AIModelProvider] = [.gemini, .openai, .claude, .local] @State private var selectedProvider: AIModelProvider = Defaults[.selectedAIProvider] @State private var selectedModel: AIModel? = Defaults[.selectedAIModel] @State private var enableThinking: Bool = Defaults[.enableThinkingMode] @@ -171,7 +172,7 @@ struct ModelSelectionView: View { .foregroundColor(.primary) LazyVGrid(columns: Array(repeating: GridItem(.flexible()), count: 2), spacing: 12) { - ForEach(AIModelProvider.allCases.filter { $0 != .groq }) { provider in + ForEach(primaryProviders) { provider in ProviderCard( provider: provider, isSelected: selectedProvider == provider, diff --git a/DynamicIsland/managers/ScreenAssistantManager.swift b/DynamicIsland/managers/ScreenAssistantManager.swift index d6fe4e0..f7f9b06 100644 --- a/DynamicIsland/managers/ScreenAssistantManager.swift +++ b/DynamicIsland/managers/ScreenAssistantManager.swift @@ -459,9 +459,9 @@ class ScreenAssistantManager: NSObject, ObservableObject { // Get selected model or default to llama-3.3-70b-versatile let selectedModel = Defaults[.selectedAIModel] - let modelId = AIModelProvider.groq.supportedModels.contains(where: { $0.id == selectedModel?.id }) - ? selectedModel!.id - : "llama-3.3-70b-versatile" + let modelId = selectedModel?.id.flatMap { selectedId in + AIModelProvider.groq.supportedModels.contains(where: { $0.id == selectedId }) ? selectedId : nil + } ?? "llama-3.3-70b-versatile" guard let url = URL(string: "https://api.groq.com/openai/v1/chat/completions") else { print("❌ ScreenAssistant: Invalid Groq API URL")